Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continente Bom Dia to supermarket in Portugal #8978

Open
DiogoBaptista98 opened this issue Nov 28, 2023 · 3 comments
Open

Add Continente Bom Dia to supermarket in Portugal #8978

DiogoBaptista98 opened this issue Nov 28, 2023 · 3 comments
Assignees
Labels
add brand Actionable - add a brand to the index

Comments

@DiogoBaptista98
Copy link

DiogoBaptista98 commented Nov 28, 2023

Add Continente Bom Dia to supermarket in Portugal
https://www.wikidata.org/wiki/Q123570507

brand=Continente Bom Dia
brand:wikidata=Q123570507
building=yes
name=Continente Bom Dia
shop=supermarket

@AntiCompositeNumber AntiCompositeNumber changed the title Add new brand Add Continente Bom Dia to supermarket in Portugal Dec 3, 2023
@AntiCompositeNumber AntiCompositeNumber added the add brand Actionable - add a brand to the index label Dec 3, 2023
@DiogoBaptista98
Copy link
Author

2 weeks for this?

@LaoshuBaby
Copy link
Collaborator

Sorry for the delay on this ticket, I found 2 similar supermarket already added to NSI

{
"displayName": "Continente",
"id": "continente-a14fce",
"locationSet": {"include": ["pt"]},
"tags": {
"brand": "Continente",
"brand:wikidata": "Q2995683",
"name": "Continente",
"shop": "supermarket"
}
},
{
"displayName": "Continente Modelo",
"id": "continentemodelo-a14fce",
"locationSet": {"include": ["pt"]},
"tags": {
"brand": "Continente Modelo",
"brand:wikidata": "Q1892188",
"name": "Continente Modelo",
"shop": "supermarket"
}
},

Please confirm whether there is a duplicate entity with the "Continente Bom Dia" you described, or is it 3 different brand(Continente, Continente Modelo, Continente Bom Dia) operator by same company?

Because I saw that their Wikidata items are the same on P856 (Official Website) http://www.continente.pt/


Additional, you can see that there are currently hundreds of issues that need to be dealt with, and many of them require manual addition of brand content. If you have certain computer skills (such as understanding json format), you can try to raise a PR directly. That's faster

@LaoshuBaby LaoshuBaby self-assigned this Dec 16, 2023
@DiogoBaptista98
Copy link
Author

Sorry for the delay on this ticket, I found 2 similar supermarket already added to NSI

{
"displayName": "Continente",
"id": "continente-a14fce",
"locationSet": {"include": ["pt"]},
"tags": {
"brand": "Continente",
"brand:wikidata": "Q2995683",
"name": "Continente",
"shop": "supermarket"
}
},
{
"displayName": "Continente Modelo",
"id": "continentemodelo-a14fce",
"locationSet": {"include": ["pt"]},
"tags": {
"brand": "Continente Modelo",
"brand:wikidata": "Q1892188",
"name": "Continente Modelo",
"shop": "supermarket"
}
},

Please confirm whether there is a duplicate entity with the "Continente Bom Dia" you described, or is it 3 different brand(Continente, Continente Modelo, Continente Bom Dia) operator by same company?

Because I saw that their Wikidata items are the same on P856 (Official Website) http://www.continente.pt/

Additional, you can see that there are currently hundreds of issues that need to be dealt with, and many of them require manual addition of brand content. If you have certain computer skills (such as understanding json format), you can try to raise a PR directly. That's faster

You’re right, this are 3 different supermarket brands by the same company.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add brand Actionable - add a brand to the index
Projects
None yet
Development

No branches or pull requests

3 participants