Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator for punctuation characters #234

Open
daniel-j-h opened this issue Jul 4, 2017 · 7 comments
Open

Validator for punctuation characters #234

daniel-j-h opened this issue Jul 4, 2017 · 7 comments

Comments

@daniel-j-h
Copy link

Can we write a validator for punctuation tokens in tags? I don't know how high the false positive rate would be but how often do punctuation characters such as

'!"#$%&\'()*+,-./:;<=>?@[\\]^_`{|}~'

occur.

If we can't do this on the name tag on all ways can we at least check it on a subset of all ways e.g. highways, ramps, etc. and then check specific tags such as name, ref, destination - basically all tags used for generating guidance instructions from?

What I'm mostly concerned about is routing engines announcing weird punctuation characters in guidance instructions to the user.

cc @srividyacb

@1ec5
Copy link
Member

1ec5 commented Jul 12, 2017

Note that some of these characters are expected in street names:

  • ' – e.g., “O’Flaherty Street”
  • ( ) ; – common in bilingual areas
  • , – e.g., “Martin Luther King, Junior Drive”
  • : – Finnish and Swedish
  • - – e.g., “Cincinnati-Dayton Road”
  • . – e.g., “8.Dezember-Straße”

A reasonably sophisticated text-to-speech engine can handle these punctuation characters well.

If we can't do this on the name tag on all ways can we at least check it on a subset of all ways e.g. highways, ramps, etc. and then check specific tags such as name, ref, destination - basically all tags used for generating guidance instructions from?

It makes sense to limit this check to street names. Business names can have a wider variety of punctuation (@ $ !).

@dannykath
Copy link

@Rub21 #256

@Rub21
Copy link
Contributor

Rub21 commented Sep 1, 2017

Thank you @dannykath, I merge the branch into master, now I am working to release the detection into to-fix.

@Rub21
Copy link
Contributor

Rub21 commented Sep 1, 2017

@Rub21
Copy link
Contributor

Rub21 commented Sep 7, 2017

@1ec5
Copy link
Member

1ec5 commented Nov 3, 2017

As mappers attempt to map both destination:ref and destination:ref:lanes simultaneously, occasionally destination:ref has wound up with | instead of ; to delimit each destination (example). Can this validator catch those issues?

@dannykath
Copy link

@Rub21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants