Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beaker wasm instantiate is missing the admin option #58

Closed
Tracked by #52
daniel-farina opened this issue Jun 28, 2022 · 0 comments · Fixed by #61
Closed
Tracked by #52

beaker wasm instantiate is missing the admin option #58

daniel-farina opened this issue Jun 28, 2022 · 0 comments · Fixed by #61
Assignees
@iboss-ptk
Labels
⚙️ task A task belongs to an epic

Comments

@daniel-farina
Copy link
Contributor

daniel-farina commented Jun 28, 2022 •
edited by iboss-ptk

I believe we need beaker wasm instantiate to support admin since it's required during the contract upgrade process.

This was pointed out in the source code here:

beaker/packages/cli/src/modules/wasm/ops/instantiate.rs

Line 48 in fd6d200

admin: None, // TODO: Fix this when working on migration

Just calling it out as a blocker for mainnet deployments as contracts would become immutable without an admin.
@daniel-farina daniel-farina added the ⚙️ task A task belongs to an epic label Jun 28, 2022
This was referenced Jun 28, 2022
Closed
Open
@iboss-ptk iboss-ptk self-assigned this Jun 30, 2022
@iboss-ptk iboss-ptk mentioned this issue Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iboss-ptk iboss-ptk

Labels
⚙️ task A task belongs to an epic
Projects
CosmWasm Ecosystem
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Option for setting contract admin osmosis-labs/beaker
2 participants
@iboss-ptk @daniel-farina