Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration over FastCache #3

Closed
ValarDragon opened this issue Jan 12, 2022 · 0 comments · Fixed by #5
Closed

Iteration over FastCache #3

ValarDragon opened this issue Jan 12, 2022 · 0 comments · Fixed by #5
Assignees

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jan 12, 2022

This should hopefully be simple:

in immutable_tree.go we should change the Iterate function to check if

t.version == t.ndb.GetLatestVersion()

If so, then we iterate over the underlying node db's keys directly. This involves looking at the key formats, but should just be a direct call on DB iterator function: https://github.com/tendermint/tm-db/blob/master/types.go#L50

We need to make sure the iterator tests test both iterating on the latest version and old versions. Also should sanity check if this is getting called in the SDK once its done. (Can do this later)

@p0mvn p0mvn self-assigned this Jan 15, 2022
@p0mvn p0mvn linked a pull request Jan 17, 2022 that will close this issue
5 tasks
@p0mvn p0mvn removed a link to a pull request Jan 20, 2022
5 tasks
@p0mvn p0mvn linked a pull request Jan 20, 2022 that will close this issue
27 tasks
@p0mvn p0mvn closed this as completed in #5 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants