Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefix Sum Tree: rename node and child structs #207

Open
ValarDragon opened this issue May 29, 2021 · 6 comments
Open

Prefix Sum Tree: rename node and child structs #207

ValarDragon opened this issue May 29, 2021 · 6 comments

Comments

@ValarDragon
Copy link
Member

Currently I think the prefix sum tree types are a bit confusing. node is actually a pointer to a node in the tree, and child is the actual node.

I suggest we rename node to nodePtr, and child to node.

What do you think @mconcat

@mconcat
Copy link
Collaborator

mconcat commented Jun 7, 2021

Absolutely agreed

@ValarDragon ValarDragon added this to To do in Upgrade 4 Aug 11, 2021
@ValarDragon ValarDragon changed the title Prefix Sum Tree: Should we rename node and child structs Prefix Sum Tree: rename node and child structs Jan 30, 2022
@jlbit
Copy link
Contributor

jlbit commented Apr 14, 2022

@ValarDragon @mconcat I was trying to find some starter tickets to work but, but looks like this one was already taken care in 4bb6f34 ?

Shall we close it to avoid other people spending more time on this?

@mconcat
Copy link
Collaborator

mconcat commented Apr 14, 2022

Sounds good!

@mconcat mconcat closed this as completed Apr 14, 2022
@ValarDragon
Copy link
Member Author

Oh I didn't realize this was done lol

@ValarDragon
Copy link
Member Author

ValarDragon commented Apr 14, 2022

Wait no, this isn't done as far as I can tell? We still have structs named Child in the logic. We should also rename ptr to something more descriptive

If you want to get started on this, I think this package can greatly be improved. E.g. a doc trying to explain code structure, laying out the logic across files better

@ValarDragon ValarDragon reopened this Apr 14, 2022
@mariaxu1019
Copy link

I see a to do for improving the diagram in the spec, is this the only improvement that could be made? Is there anything else that could be helpful for improving the spec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress🏃
Development

No branches or pull requests

4 participants