-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefix Sum Tree: rename node and child structs #207
Comments
Absolutely agreed |
@ValarDragon @mconcat I was trying to find some starter tickets to work but, but looks like this one was already taken care in 4bb6f34 ? Shall we close it to avoid other people spending more time on this? |
Sounds good! |
Oh I didn't realize this was done lol |
Wait no, this isn't done as far as I can tell? We still have structs named If you want to get started on this, I think this package can greatly be improved. E.g. a doc trying to explain code structure, laying out the logic across files better |
I see a to do for improving the diagram in the spec, is this the only improvement that could be made? Is there anything else that could be helpful for improving the spec? |
Currently I think the prefix sum tree types are a bit confusing.
node
is actually a pointer to a node in the tree, andchild
is the actual node.I suggest we rename
node
tonodePtr
, andchild
tonode
.What do you think @mconcat
The text was updated successfully, but these errors were encountered: