Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Balancer Pools #2791

Closed
Tracked by #5970
mattverse opened this issue Sep 20, 2022 · 2 comments
Closed
Tracked by #5970

Cleanup Balancer Pools #2791

mattverse opened this issue Sep 20, 2022 · 2 comments
Assignees
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:triage Issues that need to be prioritized

Comments

@mattverse
Copy link
Member

mattverse commented Sep 20, 2022

Background

We currently have many unimportant pools, that were created before pool creation fees were created.
This burdens front end developers and node operators, causing high network fees in the pools query.

Suggested Design

Proposed way of doing this is referencing https://github.com/osmosis-labs/osmosis/blob/main/x/gamm/keeper/pool.go#L115, and including it in V13.

The code snippet we've created back in the days. (We need a sincere review on this (maybe rewrite the entire function since most of the pool APIs are now outdated) as this was created long time ago).

Acceptance Criteria

  • Rewrite or have deep code review on CleanupBalancerPool
  • Add test cases for CleanupBalancerPool
@mattverse mattverse self-assigned this Sep 20, 2022
@mattverse mattverse added the C:x/gamm Changes, features and bugs related to the gamm module. label Sep 20, 2022
@mattverse mattverse added this to the V13 milestone Sep 22, 2022
@p0mvn p0mvn removed this from the V13 milestone Nov 17, 2022
@JohnnyWyles
Copy link
Collaborator

Bumping this as it has been raised again.
We have governance approval for this from the early days of the chain.
https://www.mintscan.io/osmosis/proposals/85

@p0mvn p0mvn added the T:triage Issues that need to be prioritized label Sep 26, 2023
@ValarDragon
Copy link
Member

We have decided that this does not make sense to do on-chain given the current state of Osmosis. The goal can be achieved by making a new query that skips these pools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/gamm Changes, features and bugs related to the gamm module. T:triage Issues that need to be prioritized
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants