Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rate limit to use escrowed value across all channels #3230

Open
nicolaslara opened this issue Nov 3, 2022 · 0 comments
Open

Update rate limit to use escrowed value across all channels #3230

nicolaslara opened this issue Nov 3, 2022 · 0 comments
Assignees

Comments

@nicolaslara
Copy link
Contributor

Background

In the current implementation, native tokens are rate limited based on their total supply. We want them to be rate limited based on the total amount of tokens escrowed across all channels.

Suggested Design

We can implement that by iterating over all the channels and querying their bank balance, but this is inefficient. There is an issue on ibc-go to store this information in state and allow for querying it (cosmos/ibc-go#2664). If that gets accepted, we can implement this by querying that directly.

Alternatively, if there is no interest from the ibc team in having that information be stored in state, we could ask for hooks that allows us to store that ourselves in an accumulator

Acceptance Criteria

Native tokens are rate-limited based on the total amount escrowed across all channels

@nicolaslara nicolaslara self-assigned this Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

1 participant