[CL Incentives] Allow incentives from governance proposals to bypass scaling gas costs

[AlpinYukseloglu]

Background

In #4517, we introduced a scaling gas cost for new incentive records on each uptime accumulator. This was to prevent the DoS vector of spamming new records on a pool that then need to be linearly iterated over every time the pool is poked.

It also, however, had the byproduct of risking driving up costs for gov prop-driven incentives, which are often the most frequently updated incentives and therefore would need to consistently be creating new records with scaling gas costs.

Since we can assume that going through a gov prop has stronger guarantees around preventing spam than scaling gas costs do, it would be prudent for us to special-case records that originate from governance proposals so they do not charge additional gas.

Suggested Design

• To minimize conflicts, this should likely be branched off of the farthest incentives branch from main, which is currently alpo-zero-uptime
• Add a check that skips the ConsumeGas step introduced in createIncentive in [CL Incentives] Scale gas cost for new incentives by number of existing incentives #4517

Acceptance Criteria

• All new and existing tests should pass

[ValarDragon]

I'm confused by the third point, since gov props don't pay gas?

Gov proposals are only executed in end block code.

[AlpinYukseloglu]

I'm confused by the third point, since gov props don't pay gas?

Gov proposals are only executed in end block code.

Oh wow TIL (makes complete sense in hindsight). The suggestions in this issue were out of date and not going to be implemented anyway but this is good to know.

Closing this issue now.