Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make Protorev's call for multihop estimates skip TakerFee #7521

Closed
ValarDragon opened this issue Feb 17, 2024 · 0 comments · Fixed by #7562
Closed

[Feature]: Make Protorev's call for multihop estimates skip TakerFee #7521

ValarDragon opened this issue Feb 17, 2024 · 0 comments · Fixed by #7562

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Feb 17, 2024

Protorev does not pay the taker fee in its swaps. We are unnecessarily computing the taker fee impact in protorev's multihop estimate logic. This costs us 1% of block sync's CPU time, and gives protorev less accurate internal estimates.

We should make a variant of this method:

func (k Keeper) MultihopEstimateOutGivenExactAmountIn(
that does not include the taker fee for protorev. We will likely grow to doing more in such a method natively as we aim to make protorev have less costs with CL, but that can come later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant