New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taker Fee Change for v26, Denom Lexicographically Sort #289

Open

czarcas7ic opened this issue Jun 6, 2024 · 0 comments

Member

czarcas7ic commented Jun 6, 2024

See osmosis-labs/osmosis#8344, specifically this TODO:

https://github.com/osmosis-labs/osmosis/blob/5430620767c3d9720758e5aadcd705ea45216adc/ingest/sqs/pools/transformer/pool_transformer_test.go#L495-L496

We no longer sort denoms lexicographically, so the method in sqs domain should no longer do so as well.

I am deleting the TODO in the osmosis repo in place of this issue.

czarcas7ic mentioned this issue

feat: uni-directional trading pair taker fee overrides osmosis-labs/osmosis#8344

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment