Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Test Addition #57

Open
alidehkhodaei opened this issue Jun 5, 2023 · 6 comments
Open

Request for Test Addition #57

alidehkhodaei opened this issue Jun 5, 2023 · 6 comments

Comments

@alidehkhodaei
Copy link

Hello and thank you for this project!

I believe it would be great to have tests written for this project. Is it possible to add tests?

Having tests can greatly improve the overall quality and stability of the project. It allows for easier maintenance, prevents regression bugs, and helps ensure that the project behaves as expected in different scenarios.

@github-actions
Copy link

github-actions bot commented Jun 5, 2023

Welcome @alidehkhodaei to Spring-Boot-Blog-REST-API community! Thanks so much for creating your first issue :)

@osopromadze
Copy link
Owner

Hi @alidehkhodaei, I started working on this project when I was learning and did not write tests 😄 For now I did not touch it long time.

Feel free to add tests if you would like.

@zachary-berdell-elliott

Hi, I was going backwards through codetriage.com to find a repo I could start contributing to. I saw this one and thought I would take a look.

I currently work as a Java and Spring developer. This issue seems like something I could pick up. I know a few things about writing good unit tests with JUnit.

Is this repo still actively maintained? If so, I wouldn't mind picking this up.

@zachary-berdell-elliott
Copy link

I was going to ask what the rules are for contributing and forked this repo. I guess when I create a PR, it is raised to this repo. I wrote tests for AlbumServiceImpl and will continue to write tests for more classes even if this repository is no longer maintained just for fun. https://github.com/osopromadze/Spring-Boot-Blog-REST-API/compare/main...zachary-berdell-elliott:Spring-Boot-Blog-REST-API-tests-added:feature/add-junit-tests?expand=1

@zachary-berdell-elliott

I have added unit tests for most logical code. There may still be a few cases that need to be covered though. I also fixed a bug that I found with the deleteUser method in UserServiceImpl. If this repository is still maintained or if someone stumbles across this repository and wants to work on it, feel free to merge these changes.

@vherak
Copy link

vherak commented Jul 9, 2024

!assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants