Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revenue table (Print, etc.) buttons disappear when selecting different (Reform, etc.) table #613

Closed
brittainhard opened this issue Aug 9, 2017 · 7 comments
Assignees
Labels
Milestone

Comments

@brittainhard
Copy link
Contributor

@GoFroggyRun after looking at this issue, it looks like the buttons for the table aren't being re-rendered when a different table is looked at. Unfortunately, the buttons are added after the table has already been rendered.

The buttons are added here:
https://github.com/OpenSourcePolicyCenter/webapp-public/blob/master/static/js/taxbrain-tablebuilder.js#L554-L567

But then need to be added again here after re-rendering:
https://github.com/OpenSourcePolicyCenter/webapp-public/blob/master/static/js/taxbrain-tablebuilder.js#L261-L272

So, the fiscal table is being re-rendered but it's getting rid of the buttons each time it's being re-rendered. Hope that makes sense.

I spent a couple hours looking at it and couldn't make headway. I can take another look tomorrow.

@GoFroggyRun
Copy link
Contributor

GoFroggyRun commented Aug 9, 2017

@brittainhard Thanks for looking into the issue, and pointing out related code lines. Your explanation makes a lot of sense to me.
I'll try to play with those code at the same time to see if I can get any progress or not.

@martinholmer martinholmer added this to the 1.0.2 Release milestone Aug 18, 2017
@martinholmer
Copy link
Contributor

This is still a major problem in TaxBrain 1.0.3.
@GoFroggyRun, can you fix this problem?

@MattHJensen @hdoupe @brittainhard

@martinholmer martinholmer changed the title Fiscal Table Buttons Disappear on Selecting Different Table Revenue table (Print, etc.) buttons disappear when selecting different (Reform, etc.) table Oct 3, 2017
@GoFroggyRun
Copy link
Contributor

@martinholmer Thanks for looking into this issue.

@brittainhard and I have been working on this issue. Neither of us, however, was able to fix it.
I'll take another look sometime this week to see if I can get any headway.

@GoFroggyRun
Copy link
Contributor

I have been working on this issue for a couple more days, and was able to have "something" showing up when these tables are re-rendered. However, it fails when I tried to replace "something" with the tool box.

My approach was to play with the re-render function that tries to build tool boxes after the table being re-rendered. Not too sure why it still doesn't work though.

@brittainhard do you have any input on this?

@brittainhard
Copy link
Contributor Author

@GoFroggyRun have you got some code written for this that I could take a look at?

@GoFroggyRun
Copy link
Contributor

@brittainhard I opened #705, which includes the code change as well as its effect.

@GoFroggyRun
Copy link
Contributor

@brittainhard do you have any output on this? If possible, we could do some pair programming.

cc @atxsder @MattHJensen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants