Detect only well formed URLs by running them against a valid URL regex #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the issue that prompted this pull request, try including a URL preceded immediately by a character. For example,
Notice the
a
before the URL. But Autolinker's URL parsing doesn't seem to be perfect and so, it treats the whole string as a URL and if you callmatch.getUrl()
, it also adds the protocol before it. This leads tohttp://stackoverflow.com/questions/38099684/no-suitable-url-request-handler-found
rather than the promise being gracefully rejected.To solve this, I add a well recognised regex
https://gist.github.com/dperini/729294
and use it to invalidate malformed URLs.