Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in choose_leaf results in very inefficient tree exploration #12

Open
Azureuse opened this issue Mar 4, 2021 · 1 comment
Open

Comments

@Azureuse
Copy link

Azureuse commented Mar 4, 2021

For second phase of two-phase exploration the goal is to choose the leaf with the "best bound". We are performing a minimisation problem and therefore the best lower bound is the smallest one - argmax should be argmin.

https://github.com/oxfordcontrol/miosqp/blob/master/miosqp/workspace.py#L145

Replacing it reduces the number of iterations in my problems substantially (over 100x)!

@yasirroni
Copy link

Are you sure that is not by accident? Because randomness seems play some rule in this tree search algorithm.

But, did not choosing the highest lower bound is more logical? I'm interested to test it on large MIQP problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants