Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows extension memleak related to go-winio #116

Closed
jshen14 opened this issue Oct 30, 2023 · 1 comment
Closed

windows extension memleak related to go-winio #116

jshen14 opened this issue Oct 30, 2023 · 1 comment

Comments

@jshen14
Copy link

jshen14 commented Oct 30, 2023

Hi,

I notice there is memleak related to go-winio on windows only. Is anyone else noticing similar issue? Am I missing anything when using the lib?

this is found for commit: v0.0.0-20220706183148-4e1f83012b42

and mem leak is not found in latest commit at this comment: v0.0.0-20231006172600-d6f325f636a9

@jshen14
Copy link
Author

jshen14 commented Oct 31, 2023

after debugging, I suspect it might be due to the used thrift did not close conn object

in latest thrift, I do see it close conn object

https://github.com/apache/thrift/blob/master/lib/go/thrift/simple_server.go#L209-L217

@jshen14 jshen14 closed this as completed Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant