Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide SetEffortLimit in Joint #923

Closed
osrf-migration opened this issue Oct 28, 2013 · 8 comments
Closed

Provide SetEffortLimit in Joint #923

osrf-migration opened this issue Oct 28, 2013 · 8 comments
Labels
all enhancement New feature or request minor

Comments

@osrf-migration
Copy link

Original report (archived issue) by Jesper Smith (Bitbucket: jespersmith).


I'm working on programmatically setting the effort limit, for example to limit based on a curve. It would be nice to have physics::joint::SetEffortLimit(int _index, double value) implemented in a future version of Gazebo.

Currently, I use the following hack that makes me cry on the inside

#!c++
class EffortSettableJoint : public physics::Joint
	{
	public:
		void SetEffortLimit(int _index, double value)
		{
			if (_index >= 0 && static_cast<unsigned int>(_index) < this->GetAngleCount())
			{
				this->effortLimit[_index] = value;
			}
		}
	};

(boost::static_pointer_cast<EffortSettableJoint>(joint))->SetEffortLimit(0, jointInitial.maximumforce());

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • set assignee_account_id to "557058:5de38267-b118-494c-aa76-4fab35448816"
  • set assignee to "scpeters (Bitbucket: scpeters, GitHub: scpeters)"

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


How does 6e0326a look to you? I'm targeting it to gazebo_2.1 because I think we can keep ABI compatibility by adding to the end of the class definition.

@osrf-migration
Copy link
Author

Original comment by Jesper Smith (Bitbucket: jespersmith).


Looks good to me. I don't know about ABI compatibility, we always recompile our stuff anyway.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


ABI report says compatible as of a75f344. Waiting on pull request #804

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


pull request #808

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "new" to "resolved"

pull request #808

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • set version to "all"

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


  • changed state from "resolved" to "closed"

@osrf-migration osrf-migration added minor enhancement New feature or request all labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

1 participant