Avoid range-loop-construct in TopicManager #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang (on OSX) issues a warning at the TopicManager:
```
/usr/local/Cellar/gazebo11/11.3.0/include/gazebo-11/gazebo/transport/TopicManager.hh:131:37: error: loop variable 'liter' of type 'const boost::shared_ptr<gazebo::transport::Node>' creates a copy from type 'const boost::shared_ptr<gazebo::transport::Node>' [-Werror,-Wrange-loop-construct]
for (const auto liter : iter2.second)
^
/usr/local/Cellar/gazebo11/11.3.0/include/gazebo-11/gazebo/transport/TopicManager.hh:131:26: note: use reference type 'const boost::shared_ptr<gazebo::transport::Node> &' to prevent copying
for (const auto liter : iter2.second)
^~~~~~~~~~~~~~~~~~
&
1 error generated.
```
As proposed, using it as a reference silences the warning.
scpeters
approved these changes
Apr 26, 2021
|
using OSX: 10.14.6 |
iche033
approved these changes
Apr 27, 2021
j-rivero
approved these changes
Apr 30, 2021
|
Thank you for merging. Is there any chance this can land in a new homebrew version? |
I probably need to release a new gazebo11 patch version during the next week, is that good enough for you sir? or do you want it sooner? :p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang (on OSX) issues a warning at the TopicManager:
As proposed, using it as a reference silences the warning.