Add tinyxml2 as the config name for find_package #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Oxoby <juan@vicarious.com>
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
=======================================
Coverage 87.44% 87.44%
=======================================
Files 60 60
Lines 9337 9337
=======================================
Hits 8165 8165
Misses 1172 1172 Continue to review full report at Codecov.
|
|
@osrf-jenkins run tests please |
scpeters
approved these changes
Sep 7, 2020
scpeters
added a commit
to scpeters/sdformat
that referenced
this pull request
Sep 9, 2020
Signed-off-by: Juan Oxoby <juan@vicarious.com> Co-authored-by: Juan Oxoby <juan@vicarious.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
that referenced
this pull request
Sep 10, 2020
Signed-off-by: Juan Oxoby <juan@vicarious.com> Co-authored-by: Juan Oxoby <juan@vicarious.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will look for a file named
tinyxml2Config.cmakeinstead ofTinyXML2Config.cmake. This new name matches the Conan package name. If there's a use case in which we need aTinyXML2Config.cmakefile, we can add it to the name list.