Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branch on double swing door direction for sim generation #100

Merged
merged 1 commit into from
Mar 21, 2020

Conversation

codebot
Copy link
Contributor

@codebot codebot commented Mar 20, 2020

  • branch depending on sign of motion_direction for double hinged doors when generating simulation model
  • use the motion_degrees parameter when generating double hinged doors
  • add a test map package that has a pair of double swing doors (one with positive motion direction, one with negative motion direction) that will crash into vending machines if they open the incorrect direction
  • fix an unrelated but annoying bug when trying to move models in the GUI when explicit scale or measurements were not provided

@codebot
Copy link
Contributor Author

codebot commented Mar 20, 2020

@aaronchongth @Yadunund I tested this against a minimal test case with positive and negative double-hinged doors. Can you verify if this fixes the other problems seen yesterday and today? Thanks!

Copy link
Member

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked with varying door types in office world, it works great! Thanks for the quick fix!

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works really well and the previous maps are functioning as expected!

@codebot codebot merged commit 782d67c into master Mar 21, 2020
@codebot codebot deleted the double_swing_doors_directions branch March 21, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants