Support Author-namedspaced Thumbnails and Revamp building_map_generator #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With argparse and pit_crew!
In order to ensure that pit_crew is accessible!
Also make it less fragile by allowing expansion of the home shortcut "~"
| ``` | ||
|
|
||
| Similarly, the folder `images/white/` will have been populated when the script finishes. | ||
|
|
||
| The contours of the models are then extracted from the green-screened images using OpenCV to generate a transparency mask, used for cropping the white-background images, so that it stays centered and is as small as possible. This can be done by calling, | ||
|
|
||
| ```bash | ||
| ./scripts/crop.py -m test/model_list.yaml -g images/green -w images/white -o images/cropped | ||
| ./scripts/crop.py test/model_list.yaml images/cropped -g images/green -w images/white |
There was a problem hiding this comment.
the -o argument is still required in the source code, were you intending to remove it?
aaronchongth
requested changes
May 27, 2020
|
Oh, whoops! Output dir should be optional, I'll update the readme accordingly. |
|
Output for doesn't look to be required in the source code eh :O Only in building_map_generator, but not copy.py? |
|
Yep! When you have |
|
Or do you mean the model.yaml? |
|
|
|
Clarification: I missed that in the README when I was editing it, 8dc9a5f fixes it |
|
👍 I can't merge it due to no write access though haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify
building_map_generatorbuilding_map_generatorsinto a single one and implementsargparsecommand line argument handling.gazebogenerator will callpit_crewto obtain missing models automatically when generating .world files.Support Author-namespaced Thumbnails
output_dirforcrop.pyhas been set by default to the~/.traffic_editor/assets/thumbnails/images/cropped/directory, for parity with the automatic clone on build oftraffic_editoroftraffic_editor_assetsNotes
A new package dependency for
traffic_editorhas been added. Specifically forbuilding_map_tools, in order to ensure thattraffic_editorhas access to thepit_crewdependency.Request for test: I can't test the
traffic_editorthumbnail generation pipeline due to having a different version of OpenCV (4.0.0), could someone test it out?