Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ignition plugins to ament_target_dependencies #262

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Migrate ignition plugins to ament_target_dependencies #262

merged 1 commit into from
Nov 5, 2020

Conversation

luca-della-vedova
Copy link
Member

Fixes library lookup errors in ignition demos reported in rmf_demos

@luca-della-vedova
Migrate ignition plugins to ament_target_dependencies
52f0f08 
Signed-off-by: Luca Della Vedova <luca@openrobotics.org>
Yadunund
Yadunund approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the linker error! I'm able to run the rmf_demos worlds in ign.

@luca-della-vedova luca-della-vedova merged commit 1509425 into master Nov 5, 2020
@luca-della-vedova luca-della-vedova deleted the fix/ignition_plugins_ament branch November 5, 2020 05:49
@luca-della-vedova luca-della-vedova mentioned this pull request Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@luca-della-vedova @Yadunund