Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/undo: Undo for editor components #269

Merged
merged 34 commits into from
Dec 17, 2020
Merged

Feature/undo: Undo for editor components #269

merged 34 commits into from
Dec 17, 2020

Conversation

arjo129
Copy link
Member

@arjo129 arjo129 commented Dec 7, 2020 •
edited
Loading

Part of the ongoing series of PRs with regards to undo. This PR provides undo functionality to all the mouse based tools including, edges, moving, deletion of items, rotation of models, polygon additions ad polygon edits.

Expected behavior for undoing edges:
edge_2_undo
edge_undo

@arjo129
Got initial edge undo working. Still has some bugs. In particular cha…
c6c602b 
…ining doesn't seem to be working.
@arjo129
Fixed chaining.
0243565 
Still has funny behaviour after calling undo.
@arjo129
Able to do one undo and one redo correctly. Still buggy if we go for …
ccacce5 
…more redos
@arjo129
fixes redo related bugs
8691d58
@arjo129
Uncrustified stuff
578f395
@arjo129
Ament uncrustifying
ea08756
@arjo129
untrack useless file
1264e5e
@arjo129
Adds support for moving model
0bb8d99
@arjo129
Made move_model happy again.
aa5a0d3
@arjo129
Keeping things less crusty
84914fe
@arjo129
more code formatting fixes
8171bd2
@arjo129
Add support for moving fiducials
dee9150
@arjo129
Adds undo rotate.
78832b9
@arjo129
Added support for undoing addition of fiducials
0ee98b5
@arjo129
Added undo for model add
fd0547a
@arjo129
delete now works except for with fiducials >.<.
b2fd534
@arjo129
stray character lol
37b5c9d
@arjo129
fixed the bug where first item was not being deleted.
9cf3b18
@arjo129
less crusty (I hope)
d08a772
@arjo129
re-add warning message when dealing with
34a6ead
@arjo129
style fixes.
47ac9bb
@arjo129
License headers.
4db1769
@arjo129
able to undo addition of polygons
2ac3750
@arjo129
style fixes
d214228
@arjo129
more style fixes
8c1be69
@arjo129
Adds ability to edit vertex.
0c3929e
@arjo129
license headers
a4d42e1
@arjo129
Completed support for polygon edits.
de6947d
@arjo129
remove some crust
875f4e4
@arjo129 arjo129 changed the title Feature/undo: Adding edges. Feature/undo: Undo for editor components Dec 14, 2020
@arjo129 arjo129 requested review from codebot and removed request for Yadunund December 17, 2020 03:28
codebot
codebot approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@codebot codebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a HUGE usability improvement. Thank you! 🙇

I tried various torture tests of random sequences of user inputs, and the Undo feature always worked. Thank you!

@arjo129 arjo129 merged commit a0258f2 into master Dec 17, 2020
@arjo129 arjo129 deleted the feature/undo branch December 17, 2020 08:56
@codebot codebot mentioned this pull request Apr 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebot codebot codebot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arjo129 @codebot