New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.2.1 #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hainayanda
commented
Oct 27, 2020
•
edited
edited
- Added LockRunner protocol to abstract safe multithread access
- Change RetryControl closure into escaping
- Added Finally block
- Added Timeout
- Fix Aggregate not running first aggregated request
- Make some weak variable on closure strong, since in the real implementation, there's no one keeping the variable to be strong and the variable will always be released after the closure completed
- Fix retry control called when task is cancelled
- Remove some mutating to achieve more functional code, thus less effect to any outside variable
- Added some unit test for aggregate
- Added validate and retrycontrol to unit test
- Added unit test for decoder
Devin-Kp
approved these changes
Oct 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.