Add a basic informational site #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MikeMcQuaid some screenshots would be ✨ |
|
@andrew Good idea:
I'll want to get this less LOL BOOTSTRAP before shipping. |
varjmes
reviewed
Feb 14, 2017
| @@ -1,16 +1,33 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <html class="container"> | |||
There was a problem hiding this comment.
can we add a lang="en" on this html tag?
|
I think that navigation bar might fail colour contrasts tests. Can't take a look myself right now, but you can test it using https://khan.github.io/tota11y/ :D |
Kudos to @Charlotteis for spotting and suggesting these ✨.
|
@Charlotteis Great catches, thanks! Have addressed them all and added that tool to use in development mode. |
Thanks to @lee-dohm for suggesting these 🎉.
Just to be super explicit: you were right so I switched this to use an inverse navbar. |
|
This looks like a great start, merge when ready! |
|
Good work @MikeMcQuaid, I like the addition of tota11y in dev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than jumping straight into an application that manages login/email/etc. let's add a basic static site with some basic Bootstrap theming to kick off discussion on the content and have something we could point people to today.
This is something like a 0.1 alpha; we would not be actively promoting this PR.
What I'd love help with here:
Thanks everyone ❤️!