Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always Throw errors. #7

Closed
rickihastings opened this issue Dec 5, 2013 · 4 comments
Closed

Don't always Throw errors. #7

rickihastings opened this issue Dec 5, 2013 · 4 comments
Milestone

Comments

@rickihastings
Copy link

Allow the option to be set somewhere to just return false or null instead of throwing errors.

@osslate
Copy link
Owner

osslate commented Dec 6, 2013

Due to the nature of irc-message (it's designed as an object to be instantiated via new) this isn't really possible. If you have an idea as to an alternative way to handle parsing errors, shoot.

@rickihastings
Copy link
Author

Maybe passing a boolean into it to determine whether to throw or return false.

On 6 Dec 2013, at 16:55, Fionn Kelleher notifications@github.com wrote:

Due to the nature of irc-message (it's designed as an object to be instantiated via new) this isn't really possible. If you have an idea as to an alternative way to handle parsing errors, shoot.


Reply to this email directly or view it on GitHub.

@osslate
Copy link
Owner

osslate commented Dec 6, 2013

I can't return false, only an object of some sort. I could probably

return new Boolean(false);

@rickihastings
Copy link
Author

Actually yeah that's a bit horrible. Maybe just return a valid message object but with one param which is the line that was sent? Or something.

On 6 Dec 2013, at 20:25, Fionn Kelleher notifications@github.com wrote:

I can't return false, only an object of some sort. I could probably

return new Boolean(false);

Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants