Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a case over time graph #1

Closed
yowmamasita opened this issue Mar 22, 2020 · 16 comments · Fixed by #12
Closed

Add a case over time graph #1

yowmamasita opened this issue Mar 22, 2020 · 16 comments · Fixed by #12
Assignees
Labels
tweak Issue/Pull Request for Tweaks

Comments

@yowmamasita
Copy link

Like worldometer, preferably both linear and logarithmic graphs, but linear is enough

@warengonzaga
Copy link
Member

@yowmamasita I'm thinking also of adding a graph... looking for some alternative way to show it on CLI.

@warengonzaga warengonzaga self-assigned this Mar 22, 2020
@warengonzaga warengonzaga added the tweak Issue/Pull Request for Tweaks label Mar 22, 2020
@warengonzaga
Copy link
Member

warengonzaga commented Mar 22, 2020

@yowmamasita thanks for the suggestion I will study this and will give you some updates...

@ianvizarra
Copy link
Contributor

@warengonzaga @yowmamasita https://github.com/kroitor/asciichart
This is the closest chart library I could find for generating charts in the console. Do you have any recommendations?

@warengonzaga
Copy link
Member

@warengonzaga @yowmamasita https://github.com/kroitor/asciichart
This is the closest chart library I could find for generating charts in the console. Do you have any recommendations?

Thank you, I'll take a look on this...

@ianvizarra
Copy link
Contributor

I created another endpoint for the historical graph. My initial plan was to add this to the existing endpoints but that will require an additional API call. It would be nice if the historical API supports ISO 3166-1 and include a summary of cases, deaths, active and recovered stats.

https://corona.lmao.ninja/v2/historical

@warengonzaga Any suggestions here before I create a PR?

Screen Shot 2020-03-29 at 3 23 25 PM

@warengonzaga
Copy link
Member

@ianvizarra I love to see that on version 3 you're timing... anyway.. why is it uppercase?
PHILIPPINES should be Philippines. This is for consistency.

I like the new endpoint/route on the tracker... let do it.

@warengonzaga
Copy link
Member

@ianvizarra how about something like this?

url/history/philippines/ or /all --> return national stats (is it possible to mix all of it in a graph?)

by specified endpoint...
url/history/philippines/cases
url/history/philippines/deaths
url/history/philippines/recovered
etc...

This is to avoid too much display in user's command line... let's limit it.

@warengonzaga
Copy link
Member

@ianvizarra I would suggest submit the PR on dev branch.

@ianvizarra
Copy link
Contributor

@warengonzaga

PHILIPPINES should be Philippines. This is for consistency.

Noted on this.

url/history/philippines/ or /all --> return national stats (is it possible to mix all of it in a graph?)

I can mix it's summary stats but the /all is not yet supported in the historical API

url/history/philippines/cases
url/history/philippines/deaths
url/history/philippines/recovered

as of now only cases and deaths are available in the v2/historical API

@ianvizarra
Copy link
Contributor

@ianvizarra I would suggest submit the PR on dev branch.

Noted. Just like my previous PR. gitflow approach

@warengonzaga
Copy link
Member

@ianvizarra

I can mix it's summary stats but the /all is not yet supported in the historical API

Nope, I mean this is our endpoint... just mix the data from NovelCOVID API...

@ianvizarra
Copy link
Contributor

Nope, I mean this is our endpoint... just mix the data from NovelCOVID API...
url/history/philippines/

@warengonzaga Yes, I can mix the national stats with the graph so that means calling these APIs together
https://corona.lmao.ninja/countries/:country and
https://corona.lmao.ninja/v2/historical/:country. Did I get it right? 😄

However, url/history/all will not be possible for now.

@warengonzaga
Copy link
Member

warengonzaga commented Mar 29, 2020

Nope, I mean this is our endpoint... just mix the data from NovelCOVID API...
url/history/philippines/

@warengonzaga Yes, I can mix the national stats with the graph so that means calling these APIs together
https://corona.lmao.ninja/countries/:country and
https://corona.lmao.ninja/v2/historical/:country. Did I get it right? 😄

However, url/history/all will not be possible for now.

What I mean is this...
url/history/philippines/ = covid19tracker.xyz/history/philippines || covid19tracker.xyz/history/philippines/all

Not the API itself... yeah we use the API I'm talking about our endpoint. Is that possible?

@ianvizarra
Copy link
Contributor

@warengonzaga

Screen Shot 2020-03-29 at 4 56 04 PM

@warengonzaga
Copy link
Member

@ianvizarra I like the idea!

@warengonzaga
Copy link
Member

We will close this as it is available on dev branch... expect the release on v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tweak Issue/Pull Request for Tweaks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants