Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should return error when both HLS and HTTP-TS are enabled #3391

Closed
winlinvip opened this issue Jan 28, 2023 · 3 comments · Fixed by #3400
Closed

Should return error when both HLS and HTTP-TS are enabled #3391

winlinvip opened this issue Jan 28, 2023 · 3 comments · Fixed by #3400
Assignees
Labels
EnglishNative This issue is conveyed exclusively in English. Enhancement Improvement or enhancement.
Milestone

Comments

@winlinvip
Copy link
Member

winlinvip commented Jan 28, 2023

If enable HLS and HTTP-TS, SRS can't identify the protocol(HLS or HTTP-TS) when viewer accesses the url http://x/y/z.ts, because it might be HTTP-TS or HLS file.

So, we should detect the conflict for HLS and HTTP-TS, which should return error when enable both.

See #3389 (comment)

@winlinvip winlinvip added the Enhancement Improvement or enhancement. label Jan 28, 2023
@winlinvip winlinvip added this to the 5.0 milestone Jan 28, 2023
@winlinvip winlinvip changed the title Should error when enable both HLS and HTTP-TS. Should be error when enable both HLS and HTTP-TS. Jan 28, 2023
@winlinvip winlinvip changed the title Should be error when enable both HLS and HTTP-TS. Should return error when enable both HLS and HTTP-TS. Jan 28, 2023
@winlinvip winlinvip changed the title Should return error when enable both HLS and HTTP-TS. Should return error when both HLS and HTTP-TS are enabled Jan 28, 2023
@chundonglinlin
Copy link
Member

chundonglinlin commented Jan 30, 2023

If enable http_remux HTTP-FLV and HTTP-TS, SRS only identify the first http_remux(HTTP-FLV or HTTP-TS) when viewer accesses the url http://x/y/z.flv or http://x/y/z.ts.

vhost __defaultVhost__ {
    srt {
        enabled     on;
        srt_to_rtmp on;
    }

    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].flv;
    }

    http_remux {
        enabled     on;
        mount       [vhost]/[app]/[stream].ts;
    }

    hls {
        enabled         off;
        hls_path        ./objs/nginx/html;
        hls_fragment    10;
        hls_window      60;
    }
}

So, should we detect the conflict for HTTP-FLV and HTTP-TS?

@johan149
Copy link

maybe throw an warning http_remux .ts was skipped, reading only http_remux flv with hls enabled...

@chundonglinlin
Copy link
Member

@johan149 Good! I'll pull request for adding warning.

@winlinvip winlinvip linked a pull request Feb 8, 2023 that will close this issue
@winlinvip winlinvip added the EnglishNative This issue is conveyed exclusively in English. label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnglishNative This issue is conveyed exclusively in English. Enhancement Improvement or enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants