Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow collections to be a list instead of a map #2

Closed
osteele opened this issue Jul 5, 2017 · 0 comments
Closed

Allow collections to be a list instead of a map #2

osteele opened this issue Jul 5, 2017 · 0 comments

Comments

@osteele
Copy link
Owner

osteele commented Jul 5, 2017

Implementation plan:

  • Add a struct collectionList {collections []string} type.
  • Reading config.yml unmarshals into this. If it's not empty, it creates a map and assigns the configuration from it.

The configuration struct currently specifies a map. Does this cause an error if the YAML is a list?

If so:

  • mark Config.collections with yaml:"-"
  • define collectionMap struct
  • unmarshal into collectionMap
  • assign Config.collections from collectionMap.collections
@osteele osteele closed this as completed Jul 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osteele