New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Windows build #31

Open

osteele opened this issue Jul 9, 2017 · 1 comment

Labels

Owner

osteele commented Jul 9, 2017 •

edited

Loading

See ~~https://ci.appveyor.com/project/osteele/gojekyll~~ https://github.com/osteele/gojekyll/runs/5171787377?check_suite_focus=true.

~~This issue is reported upstream at osteele/liquid#22.~~

~~Once the Liquid issue is fixed~~, wellington/go-libsass#20 may be an issue.

osteele changed the title ~~Implement Windows support~~ Build on Windows

osteele changed the title ~~Build on Windows~~ Fix Windows build

osteele changed the title ~~Fix Windows build~~ Fix Windows build (maybe just the tests?)

osteele changed the title ~~Fix Windows build (maybe just the tests?)~~ Test Windows build

Owner Author

osteele commented Feb 13, 2022

The test suite shows these errors.

There appear to be three categories of errors:

"\n" vs. "\r\n". gojekyll itself may be behaving correctly here; it might be that the fix is to set .gitattributes for the test file, or else to make the test case look for different values on Windows vs. other
time.Location("") vs. time.Local (TestPraseFilenameData). I believe that the error is in the expected value.
Windows vs Darwin/Linux path separators (I believe this is source of the remaining errors)

osteele added the help wanted label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment