Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to SlinSlo go template benchmark suite #31

Open
1 task done
mvrhov opened this issue Jun 6, 2018 · 2 comments
Open
1 task done

Add to SlinSlo go template benchmark suite #31

mvrhov opened this issue Jun 6, 2018 · 2 comments

Comments

@mvrhov
Copy link

mvrhov commented Jun 6, 2018

Checklist

Detailed Description

  • Add benchmark to the list of other template benchmarks.
  • Provide the bechnhmark results in readme until this is re-run by the author of original bench suite.
@osteele
Copy link
Owner

osteele commented Jun 10, 2018

This issue can be addressed by creating a PR against SlinSo/goTemplateBenchmark:

  • Add this package to glide.yaml
  • Create a liquid folder;
  • Translate at least the simple.* template from one of the other directories to liquid/simple.liquid.
  • Adding a function templates_test.go and templates_complex_test.go

This (osteele/liquid) package doesn't have a “precompile to go” option. The closest match is to precompile the template, and then run the compiled template. That performance is barely different from applying an uncompiled template — because most of the render time is in emulating Ruby semantics — so it probably doesn't make sense to add timings to the “precompilation to Go code” sections of SlinSo/goTemplateBenchmark's README.

@osteele
Copy link
Owner

osteele commented Jun 10, 2018

I've created a related issue #32, to add benchmarks to this (osteele/liquid) repository. This can be done independently of creating a PR to add timings to SlinSo/goTemplateBenchmark, except that the work of translating the test files from that repo into Liquid could be used for both this issue and that one.

@osteele osteele changed the title Add to benchmark suite Add to SlinSlo go template benchmark suite Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants