Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support allow_false feature #75

Open
1 of 2 tasks
ns-jjiang opened this issue Feb 13, 2023 · 0 comments
Open
1 of 2 tasks

Please support allow_false feature #75

ns-jjiang opened this issue Feb 13, 2023 · 0 comments

Comments

@ns-jjiang
Copy link

ns-jjiang commented Feb 13, 2023

Checklist

  • I have searched the issue list
  • I have tested my example against Shopify Liquid. (This isn't necessary if the actual behavior is a panic, or an error for which IsTemplateError returns false.)

Expected Behavior

Parse {{ display_price | default: true, allow_false: true }} without any error.

Actual Behavior

It shows Liquid error (line 12): syntax error in "display_price | default: true, allow_false: true" in {{ display_price | default: true, allow_false: true }}

The syntax is from the shopify document:
https://shopify.github.io/liquid/filters/default/

Detailed Description

Possible Solution

@ns-jjiang ns-jjiang reopened this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant