Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test app to demonstrate Changeset with collection view. #14

Merged
merged 3 commits into from
Mar 3, 2016

Conversation

bwhiteley
Copy link
Contributor

Added an iPhone app target to explore using Changeset while updating UICollectionView.

A naive implementation is provided for comparison.

Some of the problems identified in issue #12 are demonstrated. This example app will aid in resolving those problems, and will thereafter serve as a good example for people interested in using Changeset.

@osteslag
Copy link
Owner

Thanks a lot, @bwhiteley. I will look into this shortly.

@osteslag
Copy link
Owner

Looks like you forgot to include your CollectionViewController.swift file:

<unknown>:0: error: no such file or directory: '../notables-ios/Notables/Features/FeedFilter/CollectionViewController.swift'
Command /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/swiftc failed with exit code 1

Please commit it, and I’ll continue looking into it.

And in the meantime, do you have any idea as to what the correct Changeset behaviour should be?

@bwhiteley
Copy link
Contributor Author

How strange... I've added the missing file. Sorry about that.

At a minimum I would expect there to be a way to use the edits with UICollectionView and UITableView since both the Readme and DeLong's blog suggest it is well suited for that.

Thanks again for looking into this.

@osteslag
Copy link
Owner

The main goal for me to write Changeset is to use it with these two view classes. I have used it with table views for a while now, and haven’t encountered any problems. I’m curious to see what the problem is.

I’m also extremely busy at work at the moment (closing up on a big release), so I will have to fit it into my busy schedule.

@bwhiteley
Copy link
Contributor Author

I added a second tab to the test app that uses a table view instead of a collection view. The table view suffers from the same problem as the collection view.

@osteslag
Copy link
Owner

osteslag commented Mar 1, 2016

You’re ahead of me, @bwhiteley. Thanks! Good to hear UITableView behaves the same at least.

osteslag pushed a commit that referenced this pull request Mar 3, 2016
Add test app to demonstrate Changeset with collection, table views
@osteslag osteslag merged commit 91f4a7f into osteslag:master Mar 3, 2016
@osteslag osteslag mentioned this pull request Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants