Add ability to use a custom comparator instead a default equals - '==' #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just a short code review: is the new comperator also nessesary in the extension of |
NachoSoto
reviewed
Feb 24, 2017
| @@ -76,7 +83,28 @@ public struct Changeset<T: Collection> where T.Iterator.Element: Equatable, T.In | |||
| - returns: An array of `Edit` elements. | |||
| */ | |||
| public static func edits(from s: T, to t: T) -> [Edit<T.Iterator.Element>] { | |||
|
|
|||
| return edits(from: s, to: t) { $0 == $1 } | |||
There was a problem hiding this comment.
You can just do edits(from: s, to: t, comparator: ==). No need to create an extra closure.
|
you should add some code examples in README.md in section |
osteslag
force-pushed
the
master
branch
2 times, most recently
from
1f8b3e1
to
fa8c088
Compare
Merged
|
Fixed by #45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not enough to use a default values equality for my project and I extended the code with ability to init a Changeset with a custom comparator.
If you will find this change helpful, please, consider it to merge to your project.