Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container commit with podman #376

Closed
cgwalters opened this issue Sep 21, 2022 · 1 comment
Closed

Fix container commit with podman #376

cgwalters opened this issue Sep 21, 2022 · 1 comment

Comments

@cgwalters
Copy link
Member

Regression from #367

Basically we only added a CI test with docker, not podman. And it turns out e.g.:

$ podman run --rm -ti quay.io/coreos-assembler/fcos:testing-devel
findmnt
TARGET                  SOURCE               FSTYPE   OPTIONS
/                       overlay              overlay  rw,relatime,context="system_u:object_r:container_file_t:s0:c64,c977",lowerdir=l/4CBPNAYHPZVNIEF3LWLSFMNBLU:l/YXA7RU6QD44
...
|-/run/.containerenv    tmpfs[/containers/overlay-containers/2bbbc4c081eb2a042a6aa7e12c57ebf60ee6593041d13878a539715671e55dac/userdata/.containerenv]
|                                            tmpfs    rw,nosuid,nodev,relatime,seclabel,size=6550144k,nr_inodes=1637536,mode=700,uid=1000,gid=1000,inode64
|-/run/secrets          tmpfs[/containers/overlay-containers/2bbbc4c081eb2a042a6aa7e12c57ebf60ee6593041d13878a539715671e55dac/userdata/run/secrets]

We need to change our handling for /run and /var cleanup to not try to traverse mounts.

@cgwalters
Copy link
Member Author

Fixed by #377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant