Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dithering not functioning correctly since version 1.6.7 #95

Closed
ImagineBlaze opened this issue Feb 26, 2021 · 0 comments · Fixed by #121
Closed

Dithering not functioning correctly since version 1.6.7 #95

ImagineBlaze opened this issue Feb 26, 2021 · 0 comments · Fixed by #121
Labels
bug Something isn't working

Comments

@ImagineBlaze
Copy link
Contributor

As the title, unsightly artifacts will be produced on backgrounds when set to Low brightness, such as during gameplay with high background dim.
This is probably due to the "Use Hardware Dither" function in the game's options not working as intended.
It might be also related to the implementation of the "Set Background Quality" option, regarding color spaces.
osu!droid might have been using 6 or 7-bit color spaces since 1.6.7 which if true, will cause these artifacts.
Fixing the "High" quality background setting to display 8-bit colors might solve this issue?
The differences can be seen below. (All examples are in 25% brightness)

Screenshot from Halozy - Genryuu Kaiko Background by Hollow Wings
New droid version:
552AADC5D58745B50936D353A1C1E3E3
Old droid version:
9FFBA6E8EC5904E9693F8CCB28FAB2B3

Screenshot from HAG - Colorful Background by Sotarks
New droid version:
A34B34878996F288D1024AAD80ED1175
Old droid version:
F68DB8EE906DC365F3B4F3D0589C7B6C

Additional suggestion: Have an option to support 10-bit color spaces since there are phones which support it. (Have an option in Set Background Quality being "Very High*")

@Rian8337 Rian8337 added the bug Something isn't working label May 3, 2021
@Rian8337 Rian8337 linked a pull request May 5, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants