New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIG refactor/cleanup, and performance optimization #47
Conversation
@osunick I think I got the bugs ironed out now, looking for more testers, maybe we can release this to the beta release? |
Add EU telltale changes and unify parts that are unchanged from USDM to EU
@osunick I think it's finally ready. We could do another early access to confirm the speed limit sign bug is really fixed if you want, or just send it haha. When you do merge, I might suggest that you choose the squash and merge option so the main branch doesn't get cluttered with so many small commits from this branch. It makes it easier to read through commit history and revert PRs comprised of lots of smaller commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, mega job here.
Improvements:
power
andsmoothAmps
accessible anywhereThis shouldn't functionally or visually change anything, if something is different or unexpected, let me know.
This does include some future code for a TACC icon, but is disabled in this PR, and will be enabled in a future PR once we have an icon to use for it.
Testing
Tested with early access release, reports of noticeable fps improvements totally made this worth it :)
Comparison
Before (dark theme) and after (light theme):
https://photos.app.goo.gl/w3aGsRLAmYkPY7HS9
You can see that before frame times often went above the optimum time (green line), and many more renders were performed than necessary.
After, the renders mostly stay below the optimum frame time, and less renders are performed (which is why the graph looks stuttery, that's a good thing)