Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: add an all configuration #247

Closed
darkred opened this issue Jun 13, 2021 · 4 comments
Closed

Suggestion: add an all configuration #247

darkred opened this issue Jun 13, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@darkred
Copy link
Contributor

darkred commented Jun 13, 2021

Currently, the only configuration available is recommended (see).
The alternative the user has is to manually configure the rules he wants.

My suggestion is to offer an additional all configuration.

For reference, ESLint itself offers both recommended and all (see) configuration:

Notes from documentation:

Use "eslint:recommended" to enables a subset of core rules that report common problems.

Use "eslint:all" to enable all core rules in the currently installed version of ESLint. The set of core rules can change at any minor or major version of ESLint.

Important: This configuration is not recommended for production use because it changes with every minor and major version of ESLint. Use it at your own risk.

With the active development taking place for this plugin and the wide range of rules,
I believe it would be useful for the user to be able to try the all configuration on his project,
to see which more rules he would like to enable.

@darkred
Copy link
Contributor Author

darkred commented Jun 13, 2021

If you agree with my suggestion, I'd gladly provide my effort as a PR (I already have the changes).

@RunDevelopment
Copy link
Collaborator

This might be a good way for people to test out the plugin.

But we have to clearly communicate that this config is only intended for testing. As ESLint says: "it changes with every minor and major version". Same for our all config.

@ota-meshi What do you think?

@RunDevelopment RunDevelopment added the enhancement New feature or request label Jun 13, 2021
@ota-meshi
Copy link
Owner

It sounds good to me:+1:

@darkred
Copy link
Contributor Author

darkred commented Jun 14, 2021

I made PR #250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants