Fixed block-lang false positives for non-svelte files (#394)

Co-authored-by: ota-meshi <otameshiyo23@gmail.com>
sveltejs · Mar 7, 2023 · 4c5be6f · 4c5be6f
1 parent 3097b1b
commit 4c5be6f
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 0 deletions.
diff --git a/.changeset/eleven-guests-chew.md b/.changeset/eleven-guests-chew.md
@@ -0,0 +1,5 @@
+---
+"eslint-plugin-svelte": patch
+---
+
+fix(block-lang): fixed false positives for non-svelte files
diff --git a/src/rules/block-lang.ts b/src/rules/block-lang.ts
@@ -59,6 +59,9 @@ export default createRule("block-lang", {
     type: "suggestion",
   },
   create(context) {
+    if (!context.parserServices.isSvelte) {
+      return {}
+    }
     const enforceScriptPresent: boolean =
       context.options[0]?.enforceScriptPresent ?? false
     const enforceStylePresent: boolean =

diff --git a/tests/fixtures/rules/block-lang/valid/non-svelte/_config.json b/tests/fixtures/rules/block-lang/valid/non-svelte/_config.json
@@ -0,0 +1,10 @@
+{
+  "options": [
+    {
+      "enforceScriptPresent": true,
+      "enforceStylePresent": true,
+      "script": "ts",
+      "style": "scss"
+    }
+  ]
+}
diff --git a/tests/fixtures/rules/block-lang/valid/non-svelte/non-svelte01-input.ts b/tests/fixtures/rules/block-lang/valid/non-svelte/non-svelte01-input.ts
@@ -0,0 +1 @@
+export const value: boolean | number = false
diff --git a/tests/fixtures/rules/block-lang/valid/non-svelte/non-svelte02-input.js b/tests/fixtures/rules/block-lang/valid/non-svelte/non-svelte02-input.js
@@ -0,0 +1 @@
+export const value = false