Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed block-lang false positives for non-svelte files #394

Merged
merged 11 commits into from
Mar 7, 2023
Merged

Fixed block-lang false positives for non-svelte files #394

merged 11 commits into from
Mar 7, 2023

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Mar 6, 2023

Closes #393

@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2023

🦋 Changeset detected

Latest commit: dab92aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@marekdedic
Copy link
Contributor Author

Hmm, I can't seem to get this to work :/ I have looked at the tests for require-store-reactive-access but if I move the non-svelte dir outside valid it does not fail when it should (commented out the fix - does this maybe mean those tests don't run for require-store-reactive-acccess as well?) and also @typescript-eslint/no-unnecessary-condition but that didn't work for me as well... :( I can drop the TS test if it's too complicated but maybe I am just missing something simple?

@ota-meshi
Copy link
Member

I made a change to support test fixtures in *.ts files. #395
Could you merge it into your branch?

@ota-meshi
Copy link
Member

Could you merge it into your branch?

I just realized I can merge it 😅

@marekdedic marekdedic marked this pull request as ready for review March 7, 2023 08:47
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@ota-meshi ota-meshi merged commit 4c5be6f into sveltejs:main Mar 7, 2023
@marekdedic marekdedic deleted the block-lang-non-svelte-fix branch March 7, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

block-lang triggers on non-svelte files
2 participants