Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #28

Closed
fnoks opened this issue Feb 27, 2023 · 7 comments
Closed

Accessibility #28

fnoks opened this issue Feb 27, 2023 · 7 comments

Comments

@fnoks
Copy link
Collaborator

fnoks commented Feb 27, 2023

I have performed a quick a11y review of information wall by looking at the example here: https://h5p.org/content-types/information-wall.

  • When searching/filtering, a visually impaired user will have to navigate away from the search input to figure out whether there are results or not. I believe we should communicate this somehow while doing the filtering.
  • The main header is using h1. Since H5P most often is embedded on other pages, this means there will be two H1. That's not ideal for screenreaders. An H5P should start with h2 (or even better have it configurable, with h2 as default).
  • For each "panel" of information, there are visual headings missing semantics. I.e, if the main title is h2, then:
    • "Strawberries" should be h3
    • "Colors" and "Top 3 vitamins" should be h4
@otacke
Copy link
Owner

otacke commented Feb 27, 2023

@fnoks Thanks for taking the time to report.

  • searching/filtering: There is a dedicated function to announce the change already. If that is not working on your end, please share more details such as browser and screen reader. I just re-tested this on the latest version of Chrome with its "Screenreader" extension, and the change is announced just fine.

  • h-tags: I decided that I do not want to use h-tags at all. If someone, for instance, put the H5P content inside an h2 tag or even an h3 tag on his/her site, then you'd end up with issues again. The h1 was some code left when cleaning up. I had already added the styling to the element manually, but not replaced the tag. Changed in 20f399b I don't mind H5P core getting some function to determine the h-tag context that it is rendered in and passing that information as part of a content type's 3rd constructor argument :-)

@otacke
Copy link
Owner

otacke commented Apr 4, 2023

@fnoks Still wonder about searching/filtering.

@otacke
Copy link
Owner

otacke commented Dec 4, 2023

@fnoks Thought this might earn another "ping" to you :-)

@otacke
Copy link
Owner

otacke commented Mar 28, 2024

@fnoks Ping ...

@otacke
Copy link
Owner

otacke commented Apr 10, 2024

@fnoks Last ping. I'll consider this done next time I come across this issue.

@awludo
Copy link

awludo commented Jun 6, 2024

Hi @otacke do you think this accessibility issue still exist? If not, I think this page must be updated with correct info:
https://help.h5p.com/hc/en-us/articles/7505649072797-Content-types-recommendations
thanks

@otacke
Copy link
Owner

otacke commented Jun 6, 2024

@awludo No, that issue does not exists anymore. And it's up to H5P Group to update their info.

@otacke otacke closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants