Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrist index in data processing-'add wrist perturbation' part #2

Open
Zhengyu-Li opened this issue Jul 14, 2024 · 0 comments
Open

Wrist index in data processing-'add wrist perturbation' part #2

Zhengyu-Li opened this issue Jul 14, 2024 · 0 comments

Comments

@Zhengyu-Li
Copy link

Thanks for the great work. I have some questions about the codes.

  1. In data processing part, I found you add some perturbation to joint #18(right elbow) and #19(left wrist)
    motion_sbj_p_arms['body_pose'][:,3*18:3*19] += to_tensor(aug_rw_p)
    But according to the paper and code comments, here should be left and right elbow. Same problem for adding shoulder perturbation in next few lines. I follow the index in Grab code here https://github.com/otaheri/GRAB/blob/284cba757bd10364fd38eb883c33d4490c4d98f5/tools/utils.py#L166
  2. From my understanding of your code, the sbj_output_p is for RNet training and sbj_output_p_arms is for ANet(if wrong please correct me...). But here you send sbj_output_p_arms params to sbj_output_p. Is this a typo?
    sbj_output_p = sbj_m_h(**motion_sbj_p_arms, return_full_pose=True)

Looking forward to your reply. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant