Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should avoid side affects from namespace reuse #1

Closed
otherjoel opened this issue May 19, 2020 · 0 comments
Closed

Should avoid side affects from namespace reuse #1

otherjoel opened this issue May 19, 2020 · 0 comments

Comments

@otherjoel
Copy link
Owner

Pollen no longer explicitly resets global variables for each page render. The previous behaviour was never explicitly guaranteed, and now it is explicitly not guaranteed. Our citations implementation depends on mutating global variables, and is therefore currently broken!

There are several ways to solve this, but the simplest solution in this case will be to store our citations hash table in current-metas, which is kept fresh for each page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant