Data/XML/Groups.xml/Flags dont work

[EmperorEduardo]

If you make any changes this it doesn't work.
<flag cannotusecombat="1" />

[EPuncker]

yes it works, I've just tested

<flag cannotusecombat="1" />
try attack:
"you may not attack this creature"

<flag cannotusecombat="0" />
try attack:
succeed

[EmperorEduardo]

example: I set <flag cannotattackmonster="0" />
"you may not attack this creature"
Did you really test well?
Sscreenshot: https://i.imgur.com/BJmuFoX.png

[EPuncker]

yes I tested it well, also make sure that you are using default TFS groups.xml (that is the one that I'm using), since you seem to be using an edited one that god group id is 4, so your group_id in your database should be 4 instead of 3, next time reporting a bug, try to reproduce it with vanilla TFS,

[EmperorEduardo]

I has vanilla TFS. My bad. I tested with one.
Yes now... I needed set both options from 1 to 0
<flag cannotattackmonster="0" />
and
<flag cannotusecombat="0" />

[EPuncker]

so, bug solved? xD

[zeeb1337]

<flag cannotattackplayer="0" /> doesn't seem to work.

No changes to groups.xml and character is triple checked to be group_id 3 with account type 5.

[EPuncker]

<flag cannotattackplayer="0" /> doesn't seem to work.

No changes to groups.xml and character is triple checked to be group_id 3 with account type 5.

<flag cannotusecombat="0" /> is zero or one? the cannotattackplayer and cannotattackmonster works only together with that flag, you can't change only one and expect it to work...

right:

<flag cannotusecombat="0" /> <flag cannotattackplayer="1" />

wrong:
<flag cannotusecombat="1" /> <flag cannotattackplayer="1" />

in other words: you need to enable combat AND enable the combat type you want, either monster or player, not only one setting

[EPuncker]

@EmperorEduardo was you able to understand? if you think this is not a but, you could close this issue

[zeeb1337]

<flag cannotusecombat="0" /> -- Can use combat
<flag cannotattackplayer="0" /> -- Can attack players
<flag cannotattackmonster="0" /> -- Can attack monsters

All 3 checks out as FALSE, as they should if you want your GM to practically be an invincible player. Which means that there is obviously something wrong when I can't attack players but I can attack monsters with these settings.

Don't close it since it's still an issue.

[zeeb1337]

Now it's SOLVED

combat.cpp

bool Combat::isProtected(const Player* attacker, const Player* target)
{
	uint32_t protectionLevel = g_config.getNumber(ConfigManager::PROTECTION_LEVEL);
	if (target->getLevel() < protectionLevel || attacker->getLevel() < protectionLevel) {
		return true;
	}

	//if (attacker->getVocationId() == VOCATION_NONE || target->getVocationId() == VOCATION_NONE) {
		//return true;
	//}

	if (attacker->getSkull() == SKULL_BLACK && attacker->getSkullClient(target) == SKULL_NONE) {
		return true;
	}

	return false;
}

Switch out the old one with this in the sources please so we can bury this 5+ year old problem once and for all.