question about Lua variables

[Zbizu]

I loaded tfs folder to vs code and the editor shits itself with warnings because second value in this kind of declaration is nil:

local a, b = 10

print(a, b) -- 10   nil

examples of occurences:

forgottenserver/data/scripts/actions/tools/check_bless.lua

Line 13 in e4f02e2

local result, bless = "Received blessings:"

forgottenserver/data/actions/scripts/other/music.lua

Line 38 in e4f02e2

local instrument, chance = instruments[item:getId()]

forgottenserver/data/scripts/actions/others/clay_lump.lua

Line 11 in e4f02e2

local random, tmpItem = math.random(0, 10000) * 0.01

should this be corrected?

[nekiro]

IMO no

[marmichalski]

It does not make any sense in check_bless, it could be simplified in music, clay_lump seems the only one that makes sense 🤔

[Zbizu]

I'd personally go for more clear declaration such as:

-- one declaration, one value
local instrument = instruments[item:getId()]
-- clear declaration of local variable with no value assigned (nil)
local chance

the code is more readable for someone who isn't familiar with lua and time to execute differences are so small they don't matter if any exist

another supporting argument is that I don't see variables being declared this way uint32_t x, y = 15, 20 in source files either unless they're in a vector or a pair and have matching types

May be a bit unrelated, but this was Mark's opinion on a very short dice.lua I've wrote back in 2014:
#362 (comment)

and the file he commented on:
https://github.com/otland/forgottenserver/blob/8d931632b57c8376ccc5cbc8a32c67ac34cb50d1/data/actions/scripts/other/dice.lua

[EPuncker]

yes I agree, feel free to create a PR for the music one thought