Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items with percentage bonus attributes should recalculate the bonus value on level change #3575

Open
2 tasks done
Luckey1729 opened this issue Aug 17, 2021 · 0 comments
Open
2 tasks done
Labels
good first issue Issues that are easy to get started with

Comments

@Luckey1729
Copy link
Contributor

Before creating an issue, please ensure:

  • This is a bug in the software that resides in this repository, and not a
    support matter (use https://otland.net/forums/support.16/ for support)
  • This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

  1. Ensure that your hitpoints are set to your max hitpoints.
  2. Equip an item that utilizes an attribute such as maxhitpointspercent.
  3. Level up your character.
  4. (Optional: Take note of your hitpoints and relog, the value will change).

Expected behaviour

A character with 1000 health, on equipping an item with maxhitpointspercent attribute and a value of 105 (+5% bonus hitpoints) will have 1050 health (the value 50 will be put into varStats for this slot item). Once your character levels up (ex. a Knight gains 25 hitpoints per level) now you have 1025 hitpoints by default. The value inside varStats should be updated from 50 to 76 (rounded down from 76.25) for a total hitpoints value of 1076.

Actual behaviour

The value inside of varStats when leveling up in the above example is still 50 because the +5% bonus hitpoints from the equipped item does not get recalculated on level up.

Final thoughts

@EPuncker EPuncker added the good first issue Issues that are easy to get started with label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are easy to get started with
Projects
None yet
Development

No branches or pull requests

2 participants