Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live cast system [$205] #984

Open
Znote opened this issue Sep 10, 2014 · 15 comments
Open

Live cast system [$205] #984

Znote opened this issue Sep 10, 2014 · 15 comments
Labels
bounty enhancement Increase or improvement in quality, value, or extent

Comments

@Znote
Copy link
Member

Znote commented Sep 10, 2014

Live Cast System

twifysoft.net has a very good cast system, but I understand if they wish to keep the sources closed.
However, I believe a good live cast system will help the growth of this community, and motivate more people to jump on projects based on this repository.

So I want a live cast system, on this official repository.

How I want it to work (copied from twifysoft):

  • You can start casting by typing the command !cast ingame.
  • You can also start casting with a password, by using the command !cast password.
  • Login to the server without account name to watch a live cast.
  • If the cast has a password, enter the password in the password login field (still empty account name).
  • An in-game cast group chat channel. If the caster has the channel open, it is considered enabled, if caster is not in the channel its considered disabled.

Code quality guidelines:

@marksamman:

  • The use of the dispatcher thread must be minimal (viewers should receive a copy of the packets sent to the caster in asio thread).
  • All caster variables must be stored in (or in another object referenced from) the ProtocolGame instance of the caster player.

I will be the first here to take initiative and use Bountysource, I hope more people will follow. 👍

There is a $205 open bounty on this issue. Add to the bounty at Bountysource.

@marksamman marksamman changed the title Live cast system Live cast system [$110] Sep 10, 2014
@marksamman marksamman changed the title Live cast system [$110] Live cast system [$145] Sep 10, 2014
@Nu77
Copy link
Contributor

Nu77 commented Sep 11, 2014

Nice 👍

@mattyx14
Copy link
Contributor

yep I make my contribution

@marksamman marksamman added the enhancement Increase or improvement in quality, value, or extent label Sep 11, 2014
@EPuncker
Copy link
Contributor

great 👍 this will for sure bump the usage of tfs 1.0

@djarek djarek mentioned this issue Sep 22, 2014
@rodrigoslayertech
Copy link

If I publish my system, I get how much?

@EPuncker
Copy link
Contributor

if it fulfills all @marksamman requirements you may get the bounty I guess

@marksamman marksamman changed the title Live cast system [$145] Live cast system [$170] Jun 5, 2015
@Znote
Copy link
Member Author

Znote commented Apr 20, 2016

@marksamman @djarek Not sure whats going on with the bountysource integration, but I chipped in some extra bucks raising this from $170 to $205.

@ranisalt
Copy link
Member

@Znote it's working.
There is a $205 open bounty on this issue. Add to the bounty at Bountysource.

@gugahoa
Copy link
Contributor

gugahoa commented Apr 20, 2016

Isn't @djarek system already done and working? Most of the people that shows up with errors are using it with modifications

@Znote
Copy link
Member Author

Znote commented Apr 20, 2016

@ranisalt I edited that myself manually, the title still says $170 and it appears I cannot change that.

@gugahoa There is a pull request by djarek, but it hasn't been accepted and merged yet by Marksamman. Last thing I read there are some dodgy code in the shadows of this request that need some work for the sake of this request, as well as some good testers who know how to use a debugger. (But don't take my word for this).

I don't care if a pull request is working, it has to be merged to master or the bounty still stands.

@marksamman
Copy link
Member

There seems to be an issue with the Bountysource integration. I've tried re-enabling it without any success, until we figure it out, people interested in bounties should check the Bountysource page for the project for accurate information on bounties. As for the pull request, I'm still waiting to hear from people how well it works without additional modifications to the source code. I don't have a server with enough activity to test it myself.

@DamianDEB
Copy link

DamianDEB commented Dec 1, 2016

Djarek and Milice cast not work on tfs 1.2 final release
problem on compilling ^^
i see this system its rlly hard to be work good 🗡 ; D
`Error LIST

Severity Code Description Project File Line Suppression State
Warning C4100 'accountId': unreferenced formal parameter theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 61
Warning C4100 'forced': unreferenced formal parameter theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 158
Warning C4100 'displayEffect': unreferenced formal parameter theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 158
Warning C4100 'broadcast': unreferenced formal parameter theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 296
Error C2039 'getLevelPercent': is not a member of 'Player' theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 2752
Error C2039 'getMagicLevelPercent': is not a member of 'Player' theforgottenserver C:\Users\D\Desktop\Milice\forgottenserver-1.2\src\protocolspectator.cpp 2765

Output

1>..\src\protocolspectator.cpp(61): warning C4100: 'accountId': unreferenced formal parameter
1>..\src\protocolspectator.cpp(158): warning C4100: 'forced': unreferenced formal parameter
1>..\src\protocolspectator.cpp(158): warning C4100: 'displayEffect': unreferenced formal parameter
1>..\src\protocolspectator.cpp(296): warning C4100: 'broadcast': unreferenced formal parameter
1>..\src\protocolspectator.cpp(2752): error C2039: 'getLevelPercent': is not a member of 'Player'
1> c:\users\d\desktop\milice\forgottenserver-1.2\src\npc.h(29): note: see declaration of 'Player'
1>..\src\protocolspectator.cpp(2765): error C2039: 'getMagicLevelPercent': is not a member of 'Player'
1> c:\users\d\desktop\milice\forgottenserver-1.2\src\npc.h(29): note: see declaration of 'Player'

Protocolspectator.cpp
Line 61 - void ProtocolSpectator::login(const std::string& name, uint32_t accountId, OperatingSystem_t operatingSystem)
Line 158 - void ProtocolSpectator::logout(bool displayEffect, bool forced)
Line 296 - void ProtocolSpectator::writeToOutputBuffer(const NetworkMessage& msg, bool broadcast/* = false*/) {
Line 2752 - msg.addByte(player->getLevelPercent());
Line 2765 - msg.addByte(player->getMagicLevelPercent());

Any Solution for this ?
`

@Znote
Copy link
Member Author

Znote commented Feb 18, 2017

@djarek
#994 (comment)

I'll resubmit a new pull request when I rebase. This PR has way too many spam messages.

Could you give a status on this?

@ranisalt ranisalt changed the title Live cast system [$170] Live cast system [$205] Feb 19, 2017
@djarek
Copy link
Contributor

djarek commented Feb 20, 2017

@Znote
I want to merge #2010 before the casting system so that the latter uses the API rather than push redundant stuff into the database.

@slavidodo
Copy link
Contributor

slavidodo commented Apr 8, 2017

@Znote I will start working on this very soon!

@djarek If you have already started this, inform me and I am stopping at once!

@miezaF
Copy link

miezaF commented Oct 16, 2019

I'm going to start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty enhancement Increase or improvement in quality, value, or extent
Projects
None yet
Development

Successfully merging a pull request may close this issue.