Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up fetching expired image blocks #50

Closed
otoyo opened this issue Feb 12, 2023 · 0 comments
Closed

Speed up fetching expired image blocks #50

otoyo opened this issue Feb 12, 2023 · 0 comments
Assignees
@otoyo

Comments

@otoyo
Copy link
Owner

otoyo commented Feb 12, 2023 •
edited

When file blocks are retrieved from Nx cache, their URL (S3 signed URL) might be already expired.
So URLs must be refreshed with reloading the blocks since #49.
However, the fetching logic is time-consuming so it needs to be faster.

Idea

  1. Enqueue image blocks to queue while building
  2. Download image files to public/notion/images/ after building
@otoyo otoyo self-assigned this Feb 12, 2023
@otoyo otoyo changed the title Speed up fetching expired file blocks Speed up fetching expired image blocks Feb 13, 2023
This was referenced Feb 13, 2023
Merged
Merged
@otoyo otoyo closed this as completed Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otoyo otoyo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@otoyo