Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this be a and or an or #240

Closed
othmanesebbouh opened this issue Feb 1, 2023 · 1 comment · Fixed by #248
Closed

Should this be a and or an or #240

othmanesebbouh opened this issue Feb 1, 2023 · 1 comment · Fixed by #248

Comments

@othmanesebbouh
Copy link
Contributor

if self.is_low_rank and prob._is_low_rank_convertible:

@michalk8
Copy link
Collaborator

michalk8 commented Feb 7, 2023

Thanks, I think we can remove the 1st check, but since it's no longer LR-GW, we still have to materialize the low-rank costs, but should be fewer operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants