Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3TogglzConfig and mongoTogglzConfig can exist at the same time #261

Closed
ewoelfel opened this issue Aug 24, 2021 · 0 comments · Fixed by #268
Closed

s3TogglzConfig and mongoTogglzConfig can exist at the same time #261

ewoelfel opened this issue Aug 24, 2021 · 0 comments · Fixed by #268

Comments

@ewoelfel
Copy link
Contributor

Since release 2.4.7 it is possible to accidentally have a mongo togglz repo instead of s3 even though the config is looking like this

edison:
  togglz:
    s3:
      enabled: true
      bucket-name:someBucket

This is possible when a MongoClient is used in the service because of this matchIfMissing:

@ConditionalOnProperty(prefix = "edison.togglz", name = "mongo.enabled", havingValue = "true", matchIfMissing = true)

It would be better if the application would fail fast, if both configs are possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant