Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Font change #10

Closed
mjuzikfrik opened this issue Jun 22, 2019 · 8 comments
Closed

Suggestion: Font change #10

mjuzikfrik opened this issue Jun 22, 2019 · 8 comments

Comments

@mjuzikfrik
Copy link

Would it be possible for you to implement easy font change?
Also there's issue of text overlapping when font size is increased. Maybe it'd be good to make some panels resizeable or change their fixed width.

Screenshot_3

@Ottodix
Copy link
Owner

Ottodix commented Jun 23, 2019

Hi,
For those panels width, you can already change it from foobar> skin settings > panel layout. I would like to make it resizeable directly from the panel by dragging the borders, but it's not possible currently.

For the font change and overlapping, i'll see that later.

@mjuzikfrik
Copy link
Author

That's great. I missed that option. I think that this way is enough. :) Thanks!

@Ottodix
Copy link
Owner

Ottodix commented Jun 24, 2019

Hello,
I fixed those 2 overlapping texts. I won't implement the font change though, i'm afraid that it will create too much support issues0 You can change it yourself if you want in JStheme_common.js, in the function get_font(). Have a good day!

@mjuzikfrik
Copy link
Author

Thank you. :) Good day to you to sir!

@Ottodix
Copy link
Owner

Ottodix commented Jun 26, 2019

Hi,

I managed to do some kind of resizable borders between panels where it was possible to code this. So the library left menu, the playlist left menu, and the right playlist.
It's only available in the nightly builds for the moment. Can you test it and let me know if you find bugs? This is not incredible, it feels a little bit buggy, but it works :) Thanks
https://github.com/Ottodix/Eole-foobar-theme/zipball/master/

@mjuzikfrik
Copy link
Author

Left side works both in Library and Playlist tab but the right playlist doesn't seem to be movable. In no place I get the move cursor.

@Ottodix
Copy link
Owner

Ottodix commented Jun 26, 2019

Ah yes, it's because you didn't import again the .fcl file, and i changed the file name of the playlist script.
Now it use the default name, so you can download only this
https://github.com/Ottodix/Eole-foobar-theme/blob/master/themes/eole/js/WSHsmoothplaylist.js

and replace the existing WSHsmoothplaylist.js with the new one on your computer

@mjuzikfrik
Copy link
Author

It works :) That's really nice. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants